1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413
//! Copyright (c) 2023 MASSA LABS <info@massa.net>
use std::collections::{btree_map::Entry, BTreeMap};
use tracing::debug;
use massa_models::denunciation::DenunciationIndex;
use massa_models::slot::Slot;
use massa_models::{
address::Address,
denunciation::{Denunciation, DenunciationPrecursor},
timeslots::get_closest_slot_to_timestamp,
};
use massa_pool_exports::{PoolChannels, PoolConfig};
use massa_storage::Storage;
use massa_time::MassaTime;
pub struct DenunciationPool {
/// pool configuration
config: PoolConfig,
/// pool channels
channels: PoolChannels,
/// last consensus final periods, per thread
last_cs_final_periods: Vec<u64>,
/// Internal cache for denunciations
denunciations_cache: BTreeMap<DenunciationIndex, DenunciationStatus>,
}
impl DenunciationPool {
pub fn init(config: PoolConfig, channels: PoolChannels) -> Self {
Self {
config,
channels,
last_cs_final_periods: vec![0u64; config.thread_count as usize],
denunciations_cache: Default::default(),
}
}
/// Get the number of stored elements
pub fn len(&self) -> usize {
self.denunciations_cache
.iter()
.filter(|(_, de_st)| matches!(*de_st, DenunciationStatus::DenunciationEmitted(..)))
.count()
}
/// Checks whether an element is stored in the pool - only used in unit tests for now
#[cfg(feature = "test-exports")]
pub fn _contains(&self, denunciation: &Denunciation) -> bool {
self.denunciations_cache
.iter()
.any(|(_, de_st)| match de_st {
DenunciationStatus::Accumulating(_) => false,
DenunciationStatus::DenunciationEmitted(de) => de == denunciation,
})
}
/// Add a denunciation precursor to the pool - can lead to a Denunciation creation
/// Note that the Denunciation is stored in the denunciation pool internal cache
pub fn add_denunciation_precursor(&mut self, denunciation_precursor: DenunciationPrecursor) {
let slot = denunciation_precursor.get_slot();
// Do some checkups before adding the denunciation precursor
if slot.period <= self.config.last_start_period {
// denunciation created before last restart (can be 0 or >= 0 after a network restart) - ignored
// Note: as we use '<=', also ignore denunciation created for genesis block
return;
}
let now = MassaTime::now();
// get closest slot according to the current absolute time
let slot_now = get_closest_slot_to_timestamp(
self.config.thread_count,
self.config.t0,
self.config.genesis_timestamp,
now,
);
// Note about last_cs_final_periods.iter().min()
// Unlike operations, denunciations can be included in any thread
// So Denunciations can only be expired when they cannot be included in any thread
if Denunciation::is_expired(
&slot.period,
self.last_cs_final_periods.iter().min().unwrap_or(&0),
&self.config.denunciation_expire_periods,
) {
// too old - cannot be denounced anymore
return;
}
if slot.period.saturating_sub(slot_now.period) > self.config.denunciation_expire_periods {
// too much in the future - ignored
return;
}
// Get selected address from selector and check
// Note: If the public key of the header creator is not checked to match the PoS,
// someone can spam with headers coming from various non-PoS-drawn pubkeys
// and cause a problem
match &denunciation_precursor {
DenunciationPrecursor::Endorsement(de_p) => {
// Get selected address from selector and check
let selected = self.channels.selector.get_selection(de_p.slot);
match selected {
Ok(selection) => {
if let Some(address) = selection.endorsements.get(de_p.index as usize) {
let a = Address::from_public_key(&de_p.public_key);
if *address != a {
debug!("Denunciation pool received a secure share endorsement but address was not selected: received {} but expected {} ({})", address, a, de_p.public_key);
return;
}
} else {
debug!("Denunciation pool could not get selected address for endorsements at index");
return;
}
}
Err(e) => {
debug!("Cannot get producer from selector: {}", e);
return;
}
}
}
DenunciationPrecursor::BlockHeader(de_p) => {
let selected_address = self.channels.selector.get_producer(de_p.slot);
match selected_address {
Ok(address) => {
if address
!= Address::from_public_key(denunciation_precursor.get_public_key())
{
debug!("Denunciation pool received a secured header but address was not selected");
return;
}
}
Err(e) => {
debug!("Cannot get producer from selector: {}", e);
return;
}
}
}
}
let key = DenunciationIndex::from(&denunciation_precursor);
let denunciation_: Option<Denunciation> = match self.denunciations_cache.entry(key) {
Entry::Occupied(mut eo) => match eo.get_mut() {
DenunciationStatus::Accumulating(de_p_) => {
let de_p: &DenunciationPrecursor = de_p_;
if *de_p != denunciation_precursor {
match Denunciation::try_from((de_p, &denunciation_precursor)) {
Ok(de) => {
eo.insert(DenunciationStatus::DenunciationEmitted(de.clone()));
Some(de)
}
Err(e) => {
debug!("Denunciation pool cannot create denunciation from endorsements: {}", e);
None
}
}
} else {
// same denunciation precursor - do nothing
None
}
}
DenunciationStatus::DenunciationEmitted(..) => {
// Already 2 entries - so a Denunciation has already been created
None
}
},
Entry::Vacant(ev) => {
ev.insert(DenunciationStatus::Accumulating(denunciation_precursor));
None
}
};
if let Some(denunciation) = denunciation_ {
debug!("Created a new denunciation : {:?}", denunciation);
}
// Because at the start of the function, we have already checked that DE precursor is not
// expired, there is no need to cleanup the cache here
// This is only needed when we are notified of new cs final periods and thus calling the
// cleanup function only when it is needed
}
/// cleanup internal cache, removing too old denunciation
fn cleanup_caches(&mut self) {
cleanup_cache(
&mut self.denunciations_cache,
self.last_cs_final_periods.iter().min().unwrap_or(&0),
&self.config.denunciation_expire_periods,
);
}
/// get denunciations for block creation
pub fn get_block_denunciations(&self, target_slot: &Slot) -> Vec<Denunciation> {
let mut res = Vec::with_capacity(self.config.max_denunciations_per_block_header as usize);
for (de_idx, de_status) in &self.denunciations_cache {
if let DenunciationStatus::DenunciationEmitted(de) = de_status {
// Checks
// 1. the denunciation has not been executed already
// 2. Denounced item slot is equal or before target slot of block header
// 3. Denounced item slot is not too old
let de_slot = de.get_slot();
if !self
.channels
.execution_controller
.get_denunciation_execution_status(de_idx)
.0
&& de_slot <= target_slot
&& !Denunciation::is_expired(
&de_slot.period,
&target_slot.period,
&self.config.denunciation_expire_periods,
)
{
res.push(de.clone());
}
}
if res.len() >= self.config.max_denunciations_per_block_header as usize {
break;
}
}
res
}
/// Notify of final periods
pub(crate) fn notify_final_cs_periods(&mut self, final_cs_periods: &[u64]) {
// update internal final CS period counter
self.last_cs_final_periods = final_cs_periods.to_vec();
// remove all denunciations that are expired
self.cleanup_caches()
}
/// Add endorsements, turn them in DenunciationPrecursor then process
pub(crate) fn add_endorsements(&mut self, endorsement_storage: Storage) {
let precursors: Vec<DenunciationPrecursor> = {
let endorsement_store = endorsement_storage.read_endorsements();
endorsement_storage
.get_endorsement_refs()
.iter()
.map(|id| {
DenunciationPrecursor::from(
endorsement_store
.get(id)
.expect("could not get endorsement owned by storage"),
)
})
.collect()
};
for precursor in precursors {
self.add_denunciation_precursor(precursor);
}
}
}
/// Internal function to cleanup the denunciation cache
fn cleanup_cache(
cache: &mut BTreeMap<DenunciationIndex, DenunciationStatus>,
slot_period: &u64,
denunciation_expire_periods: &u64,
) {
// Compute the first key which is not expired
// Note 1: that in order to use split_off, there is no need for the key to exist in the BTreeMap
// Note 2: earliest_allowed_period is compat with DenunciationIndex::is_expired(..) method
let earliest_allowed_period = slot_period.saturating_sub(*denunciation_expire_periods);
// Use DenunciationIndex::BlockHeader here as the PartialEq impl use DenunciationIndexTypeId
// and BlockHeader is the one with the lowest value
let de_idx = DenunciationIndex::BlockHeader {
slot: Slot::new(earliest_allowed_period, 0),
};
// Keep only non expired items
*cache = cache.split_off(&de_idx);
}
/// A Value (as in Key/Value) for denunciation pool internal cache
#[derive(Debug, Clone, PartialEq)]
enum DenunciationStatus {
/// Only 1 DenunciationPrecursor received for this key
Accumulating(DenunciationPrecursor),
/// 2 DenunciationPrecursor received, a Denunciation was then created
DenunciationEmitted(Denunciation),
}
#[cfg(test)]
mod tests {
use super::*;
use std::collections::Bound::Included;
use std::ops::Bound::Unbounded;
use massa_hash::Hash;
use massa_models::block_header::{BlockHeader, BlockHeaderSerializer};
use massa_models::block_id::BlockId;
use massa_models::config::{CHAINID, ENDORSEMENT_COUNT};
use massa_models::endorsement::{Endorsement, EndorsementSerializer};
use massa_models::secure_share::SecureShareContent;
use massa_signature::KeyPair;
#[test]
fn test_cache_cleanup() {
// Test cleanup_cache() function
// Note that removing comment about function timings shows a huge diff (ms versus µs)
let keypair = KeyPair::generate(0).unwrap();
let bound_1 = 10_000;
let bound_2_st = 500;
let bound_2 = 30_000;
let de_index_iter = (1..bound_1).map(|i| DenunciationIndex::BlockHeader {
slot: Slot::new(i, 0),
});
let de_status_iter = (1..bound_1).map(|i| {
let block_header_1 = BlockHeader {
current_version: 0,
announced_version: None,
slot: Slot::new(i, 0),
parents: vec![],
operation_merkle_root: Hash::compute_from("mno".as_bytes()),
endorsements: vec![],
denunciations: vec![],
};
// create header
let s_block_header_1 = BlockHeader::new_verifiable::<BlockHeaderSerializer, BlockId>(
block_header_1,
BlockHeaderSerializer::new(),
&keypair,
*CHAINID,
)
.expect("error while producing block header");
// let s_h = SecuredShare::
DenunciationStatus::Accumulating(DenunciationPrecursor::from(&s_block_header_1))
});
let de_index_iter_2 = (bound_2_st..bound_2).map(|i: u32| DenunciationIndex::Endorsement {
slot: Slot::new(u64::from(i), 0),
index: i % ENDORSEMENT_COUNT,
});
let de_status_iter_2 = (bound_2_st..bound_2).map(|i| {
let endorsement_1 = Endorsement {
slot: Slot::new(u64::from(i), 0),
index: i % ENDORSEMENT_COUNT,
endorsed_block: BlockId::generate_from_hash(Hash::compute_from("blk1".as_bytes())),
};
let s_endorsement1 = Endorsement::new_verifiable(
endorsement_1,
EndorsementSerializer::new(),
&keypair,
*CHAINID,
)
.unwrap();
DenunciationStatus::Accumulating(DenunciationPrecursor::from(&s_endorsement1))
});
let de_cache: BTreeMap<DenunciationIndex, DenunciationStatus> = BTreeMap::from_iter(
de_index_iter
.zip(de_status_iter)
.chain(de_index_iter_2.zip(de_status_iter_2)),
);
// println!("de_cache len: {:?}", de_cache.len());
let last_slot_period = 100;
let denunciation_expire_periods = 10;
// Keep this old and slow method for
// * benchmarking
// * more readable and explicit code (compared to cleanup_cache impl)
let mut de_cache_cleanup_1 = de_cache.clone();
// use std::time::Instant;
// let bench_time_start_1 = Instant::now();
de_cache_cleanup_1.retain(|de_idx, _| {
let slot = de_idx.get_slot();
!Denunciation::is_expired(
&slot.period,
&last_slot_period,
&denunciation_expire_periods,
)
});
// println!("Elapsed time: {:.6?}", bench_time_start_1.elapsed());
let mut de_cache_cleanup_2 = de_cache.clone();
// let bench_time_start_2 = Instant::now();
cleanup_cache(
&mut de_cache_cleanup_2,
&last_slot_period,
&denunciation_expire_periods,
);
// println!("Elapsed time: {:.6?}", bench_time_start_2.elapsed());
assert_eq!(de_cache_cleanup_1, de_cache_cleanup_2);
// Compared to expected result so we do not depend on DenunciationIndex PartialEq impl here
let bound = Included(DenunciationIndex::BlockHeader {
slot: Slot::new(90, 0),
});
assert_eq!(
de_cache_cleanup_2,
de_cache
.range((bound, Unbounded))
.map(|(k, v)| (*k, v.clone()))
.collect::<BTreeMap<DenunciationIndex, DenunciationStatus>>()
);
}
}